Make document auto-saving include the active tab index instead of just restoring the last tab #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
reviewed
Jan 12, 2025
| if (!previouslySavedDocuments || !documentOrder) return; | ||
|
|
||
| const orderedSavedDocuments = documentOrder.flatMap((id) => (previouslySavedDocuments[id] ? [previouslySavedDocuments[id]] : [])); | ||
|
|
||
| orderedSavedDocuments?.forEach(async (doc: TriggerIndexedDbWriteDocument) => { | ||
| editor.handle.openAutoSavedDocument(BigInt(doc.details.id), doc.details.name, doc.details.isSaved, doc.document); | ||
| }); | ||
| if (!!currentDocumentId){ |
There was a problem hiding this comment.
The !! is redundant here. Please also watch your formatting with there being no space between the ) and {. Your editor must be not set up to format on autosave, so you might want to get cd frontend && npm run lint-fix to run in your post-commit hook or format on save.
|
!build |
|
|
Only autosaved documents get serialized to the browser storage, which can get the indexes out of sync. Reproduction:
|
Keavon
changed the title
mTvare6
force-pushed
the
reload-last-active-tab
branch
from
23a5ec0 to
addf7e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://discord.com/channels/731730685944922173/881073965047636018/937518022548131891